plc/plc.h: fix build with gcc 10 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1000
requested changes
Sep 26, 2020
There was a problem hiding this comment.
Thanks for the patch Fabrice. Looking at the nearby structures in this file it looks like most of them also create a type using typedef. I think this may have been the original intent but was missed by the original author. Can you modify your pull request to do the same?
Thanks!
Add typedef to plcproperty structure to avoid the following build failure with gcc 10 (which defaults to -fno-common): /home/buildroot/autobuild/run/instance-3/output-1/host/lib/gcc/arm-buildroot-linux-gnueabihf/10.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: rules.o:(.bss+0x0): multiple definition of `plcproperty'; pibruin.o:(.bss+0x0): first defined here Fixes: - http://autobuild.buildroot.org/results/6b3064b64dea3d4aaf219f787429c25918101483 Signed-off-by: Fabrice Fontaine <[email protected]>
|
Done |
|
Thanks, merged! |
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jun 25, 2023
…c5dc4e89cf2 Other changes: - Remove 0002-plc-plc.h-fix-build-with-gcc-10.patch as related MR qca/open-plc-utils#141 has been merged. Notable changes since last version: - Drop privileges after opening the channel file descriptor - Remove all checks for root permissions - Add chip identification for QCA7006AQ Signed-off-by: Kai Stuhlemmer (ebee Engineering) <[email protected]> Signed-off-by: Arnout Vandecappelle <[email protected]>
citral23
pushed a commit
to citral23/buildroot
that referenced
this pull request
Sep 18, 2023
…c5dc4e89cf2 Other changes: - Remove 0002-plc-plc.h-fix-build-with-gcc-10.patch as related MR qca/open-plc-utils#141 has been merged. Notable changes since last version: - Drop privileges after opening the channel file descriptor - Remove all checks for root permissions - Add chip identification for QCA7006AQ Signed-off-by: Kai Stuhlemmer (ebee Engineering) <[email protected]> Signed-off-by: Arnout Vandecappelle <[email protected]>
davidschneider-cpi
pushed a commit
to ChargePoint/buildroot
that referenced
this pull request
Apr 19, 2024
…c5dc4e89cf2 Other changes: - Remove 0002-plc-plc.h-fix-build-with-gcc-10.patch as related MR qca/open-plc-utils#141 has been merged. Notable changes since last version: - Drop privileges after opening the channel file descriptor - Remove all checks for root permissions - Add chip identification for QCA7006AQ Signed-off-by: Kai Stuhlemmer (ebee Engineering) <[email protected]> Signed-off-by: Arnout Vandecappelle <[email protected]> (cherry picked from commit 39fef04)
davidschneider-cpi
pushed a commit
to ChargePoint/buildroot
that referenced
this pull request
Apr 22, 2024
…c5dc4e89cf2 Other changes: - Remove 0002-plc-plc.h-fix-build-with-gcc-10.patch as related MR qca/open-plc-utils#141 has been merged. Notable changes since last version: - Drop privileges after opening the channel file descriptor - Remove all checks for root permissions - Add chip identification for QCA7006AQ Signed-off-by: Kai Stuhlemmer (ebee Engineering) <[email protected]> Signed-off-by: Arnout Vandecappelle <[email protected]> (cherry picked from commit 39fef04)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop plcproperty from plc/plc.h to avoid the following build failure with gcc 10 (which defaults to -fno-common):
Fixes:
Signed-off-by: Fabrice Fontaine [email protected]