Add missing typedef for plcproperty #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compilation with Ubuntu 20.10 uncovered the following linker problem: /usr/bin/ld: rules.o:(.bss+0x0): multiple definition of `plcproperty'; pibruin.o:(.bss+0x0): first defined here /usr/bin/ld: ParseRule.o:(.bss+0x0): multiple definition of `plcproperty'; pibruin.o:(.bss+0x0): first defined here /usr/bin/ld: piblock.o:(.bss+0x0): multiple definition of `plcproperty'; pibruin.o:(.bss+0x0): first defined here /usr/bin/ld: ruledump.o:(.bss+0x0): multiple definition of `plcproperty'; pibruin.o:(.bss+0x0): first defined here collect2: error: ld returned 1 exit status When looking at the include file plc.h, we find that the typedef keyword is missing which in turn results in a variable declaration - which is usually not wanted in header files. Signed-off-by: Michael Heimpold <[email protected]>
|
Hi Michael, I think this issue should be fixed by 003bfe0 , can you confirm? Thanks, |
|
Hi @n1000, yep, it works. Don't know why, but somehow I missed this commit and still worked on an older commit. At least, I came to the same solution. Sorry for the noise + thanks for your hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation with Ubuntu 20.10 uncovered the following linker problem:
/usr/bin/ld: rules.o:(.bss+0x0): multiple definition of
plcproperty'; pibruin.o:(.bss+0x0): first defined here /usr/bin/ld: ParseRule.o:(.bss+0x0): multiple definition ofplcproperty'; pibruin.o:(.bss+0x0): first defined here/usr/bin/ld: piblock.o:(.bss+0x0): multiple definition of
plcproperty'; pibruin.o:(.bss+0x0): first defined here /usr/bin/ld: ruledump.o:(.bss+0x0): multiple definition ofplcproperty'; pibruin.o:(.bss+0x0): first defined herecollect2: error: ld returned 1 exit status
When looking at the include file plc.h, we find that the typedef keyword
is missing which in turn results in a variable declaration - which is
usually not wanted in header files.
Signed-off-by: Michael Heimpold [email protected]