Fix chipset reporting (fixes #151) #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two types are listed in the comment above and/or in the bootrom list already, but they are missing in the firmware list. Signed-off-by: Michael Heimpold <[email protected]>
Storing this field already here saves us from having the same logic of looking at different response offsets twice. Signed-off-by: Michael Heimpold <[email protected]>
This new function determines the chipset name based on the ident field in VS_SW_VER.CNF. It also implements a fallback to the chipsetname function in case an unknown ident value is given, or we use this when the same ident value is ambiguous without inspecting the device class field additionally. Signed-off-by: Michael Heimpold <[email protected]>
This uses the newly introduced function and thus fixes Github issue qca#151. Signed-off-by: Michael Heimpold <[email protected]>
barsnick
pushed a commit
to chargebyte/meta-chargebyte-distro
that referenced
this pull request
Nov 29, 2021
While waiting for upstream to merge PR #152 qca/open-plc-utils#152 we switch to our fork to have the function available as desired. Signed-off-by: Michael Heimpold <[email protected]>
|
@n1000 : any objections here? |
|
Hey @mhei , this change looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #151, reporting the chipset name is not working as expected - at least as I would expect.
This PR tries solves this issue by introducing a new function which not only considers the MCLASS field
as older chipsetname function does, but by relying on the IDENT field in the response MME.
Signed-off-by: Michael Heimpold [email protected]