Skip to content

Commit

Permalink
Remove changeset for publishing (#35)
Browse files Browse the repository at this point in the history
* wip: replace changeset publish with simple publish

* wip: publish publicly

* remove generated OpenAPI update check

* remove obsolete changeset directory

* update contributing docs

* remove changesets from deps

* update releases docs

---------

Co-authored-by: Ivan Pleshkov <[email protected]>
  • Loading branch information
generall and IvanPleshkov authored Jul 31, 2023
1 parent f12fe1e commit c6f1214
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 1,446 deletions.
8 changes: 0 additions & 8 deletions .changeset/README.md

This file was deleted.

11 changes: 0 additions & 11 deletions .changeset/config.json

This file was deleted.

9 changes: 0 additions & 9 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@ jobs:
env:
CI: 1

- name: Generated OpenAPI update check
run: |
pnpm --filter "@qdrant/js-client-rest" codegen:openapi-typescript
if ( git diff --name-only | grep -q packages/js-client-rest/src/openapi/ || exit ) then
echo "Generated schema changed. Please update with: 'pnpm -r codegen:openapi-typescript'.";
exit 1
fi
shell: bash

- name: Project checks
run: pnpm -r pre-check

Expand Down
15 changes: 5 additions & 10 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Release

on:
workflow_dispatch:
push:
branches: [master]
tags:
- '*'

concurrency: ${{ github.workflow }}-${{ github.ref }}

Expand Down Expand Up @@ -43,15 +45,8 @@ jobs:
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Create release pull request or publish to npm
id: changesets
uses: changesets/action@v1
with:
version: pnpm ci:version
publish: pnpm ci:release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
- run: node scripts/prepublish.mjs
- run: pnpm publish --access public

- name: Archive npm failure logs
uses: actions/upload-artifact@v3
Expand Down
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ Pull requests are the best way to propose changes to the codebase (we use [Githu
2. If you've added code that should be tested, add tests.
3. Make sure your code lints: `pnpm pre-check`. The root package installs a `pre-commit` hook with [husky](https://github.com/typicode/husky/) to automate this check.
4. Ensure the test suite passes: `pnpm test`.
5. When ready, use [Changesets](https://github.com/changesets/changesets): `pnpm changeset` to describe the change(s). The generated markdown files in the `.changeset` directory should be committed to the repository.
6. Issue that pull request!
5. Update `CHANGELOG.md` and version in packages.
6. Check if `QDRANT_LATEST` env variable is latest if you updated major or minor version.
7. Issue that pull request!

## Any contributions you make will be under the Apache License 2.0

Expand Down
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,7 @@ TypeScript types are provided alongside JavaScript sources to be used in:

## Releases

Major and minor versions align with Qdrant's engine releases, whilst patch are reserved for fixes regarding the current minor release. Check out [RELEASE.md](./RELEASE.md) for more info on release guidelines.

For release automation we use [`changesets`](https://github.com/changesets/changesets) both for pull requests and pushes to the master branch, and their [Github Action](https://github.com/changesets/action) to automate changeset steps.
Major and minor versions align with Qdrant's engine releases, whilst patch are reserved for fixes regarding the current minor release. New releases are made from the `master` branch.

## Contributing

Expand Down
38 changes: 0 additions & 38 deletions RELEASE.md

This file was deleted.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
"*.{md,yaml}": "prettier --list-different"
},
"devDependencies": {
"@changesets/changelog-github": "^0.4.8",
"@changesets/cli": "^2.26.1",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-terser": "^0.4.1",
"@types/node": "^20.1.3",
Expand Down
Loading

0 comments on commit c6f1214

Please sign in to comment.