refactor: Enhance URL handling in QdrantClientConfig #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update gRPC definitions * Remove now obsolete Google protobuf definitions * Add batch update methods to client * Bump version to 1.5.0
* bump create version * ignore intellij config file * regen client * update test image version * add geo-polygon condition builder * format example * dependencies updates * filter out new healcheck proto
* sync * compile * bump deps * bump version * fmt * regen * fix * add convenience conversion for sparse vectors * fix sparse vector converter * fix sparse vector converter * remove shard_snapshots_service * restore version * more conversion * one last conversion * Reformat --------- Co-authored-by: timvisee <[email protected]>
* Add create and delete shard key functions * Use more direct shard key types * Add discovery functions * Conversions from borrowed types into sparse vectors * Add shard key selector parameter to all relevant API functions * Move shard key selector parameter adjacent collection name parameter * Update documentation example * Add conversion helpers for shard key selector * sync proto * proto changes * fix readme --------- Co-authored-by: generall <[email protected]>
* Add `update_collection_extended` * Update `update_collection` to `update_collection_extended`
* Bump version to 1.7.0 * Bump version to 1.7.0 in integration test
This commit improves the URL handling mechanism in the QdrantClientConfig's `from_url` function. The primary aim is to ensure that the Qdrant service URL is always fully specified, including a default port if one is not provided in the input URL. This enhancement makes the client's connection setup more robust and error-tolerant, especially in environments where the port might not be explicitly specified. Changes include: - Parsing the input URL using the `url` crate to create a `Url` instance. - Checking for the presence of a port in the parsed URL. If absent, the default port 6334 is assigned. These modifications ensure that the QdrantClientConfig is initialized with a complete URL, reducing the potential for runtime errors during the client's interaction with the Qdrant service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the URL handling mechanism in the QdrantClientConfig's
from_urlfunction. The primary aim is to ensure that the Qdrant service URL is always fully specified, including a default port if one is not provided in the input URL. This enhancement makes the client's connection setup more robust and error-tolerant, especially in environments where the port might not be explicitly specified.Changes include:
urlcrate to create aUrlinstance.These modifications ensure that the QdrantClientConfig is initialized with a complete URL, reducing the potential for runtime errors during the client's interaction with the Qdrant service.