-
Notifications
You must be signed in to change notification settings - Fork 3
refactor "network module" #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
turuslan
commented
Sep 10, 2025
- address network module #8 comments
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors the network module to address comments from issue #8, focusing on removing macro-based code generation and improving code organization.
- Removes deprecated macro-based subscription system and replaces it with explicit type-safe implementations
- Extracts protocol implementations into separate files for better modularity
- Consolidates networking types and removes duplicated StatusMessage definition
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vcpkg-overlay/qtils/vcpkg.patch | Removes patch content (likely no longer needed) |
| vcpkg-overlay/qtils/portfile.cmake | Updates qtils library to version v0.1.4 |
| src/types/status_message.hpp | Removes file - type moved to networking module |
| src/serde/snappy.hpp | Adds inline keywords to compression functions |
| src/se/subscription.hpp | Adds SimpleSubscription template class for type-safe subscriptions |
| src/modules/shared/networking_types.tmp.hpp | Updates include to use networking types instead of status_message |
| src/modules/shared/macro.hpp | Removes deprecated macro definitions |
| src/modules/production/* | Updates function names from snake_case to camelCase |
| src/modules/networking/* | Major refactor: extracts protocols to separate files, removes macros, updates naming |
| src/loaders/impl/* | Updates to use new subscription system and naming conventions |
| src/blockchain/* | Removes getStatusMessage method (logic moved to networking module) |
| DEPRECATED.md | Documents deprecated patterns and coding standards |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: turuslan <[email protected]>