Skip to content

Conversation

@turuslan
Copy link
Contributor

Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from xDimon September 10, 2025 12:49
@turuslan turuslan requested a review from iceseer September 15, 2025 06:51
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from xDimon September 15, 2025 10:00
@kamilsa kamilsa requested a review from Copilot September 18, 2025 10:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the network module to address comments from issue #8, focusing on removing macro-based code generation and improving code organization.

  • Removes deprecated macro-based subscription system and replaces it with explicit type-safe implementations
  • Extracts protocol implementations into separate files for better modularity
  • Consolidates networking types and removes duplicated StatusMessage definition

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vcpkg-overlay/qtils/vcpkg.patch Removes patch content (likely no longer needed)
vcpkg-overlay/qtils/portfile.cmake Updates qtils library to version v0.1.4
src/types/status_message.hpp Removes file - type moved to networking module
src/serde/snappy.hpp Adds inline keywords to compression functions
src/se/subscription.hpp Adds SimpleSubscription template class for type-safe subscriptions
src/modules/shared/networking_types.tmp.hpp Updates include to use networking types instead of status_message
src/modules/shared/macro.hpp Removes deprecated macro definitions
src/modules/production/* Updates function names from snake_case to camelCase
src/modules/networking/* Major refactor: extracts protocols to separate files, removes macros, updates naming
src/loaders/impl/* Updates to use new subscription system and naming conventions
src/blockchain/* Removes getStatusMessage method (logic moved to networking module)
DEPRECATED.md Documents deprecated patterns and coding standards

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@turuslan turuslan enabled auto-merge (squash) September 18, 2025 11:28
@turuslan turuslan merged commit 18e8815 into master Sep 18, 2025
2 checks passed
@turuslan turuslan deleted the refactor/network branch September 18, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants