generate genesis files #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
turuslan
force-pushed
the
feature/genesis
branch
from
0e06cbc to
f47ca0a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to generate genesis configuration files for a blockchain network. The command qlean generate-genesis creates a directory structure with configuration files for network validators and nodes, including cryptographic keys and ENR (Ethereum Node Records).
Key changes:
- Introduced
generate-genesiscommand that creates genesis configuration files (config.yaml, nodes.yaml, validators.yaml, validator-config.yaml, and node key files) - Enhanced ENR encoding/decoding with signature verification and support for custom IP addresses
- Updated
SamplePeerutility to support both localhost and shadow network IP configurations
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vcpkg-overlay/leanp2p/portfile.cmake | Updated leanp2p dependency to newer commit reference |
| src/utils/sample_peer.hpp | Refactored to support shadow network IPs and proper ENR generation |
| src/serde/enr.hpp | Added IP utilities, signature support, and updated encode function signature |
| src/serde/enr.cpp | Implemented signature verification/generation and refactored encoding logic |
| src/executable/lean_node.cpp | Integrated generate-genesis command handler |
| src/commands/generate_genesis.hpp | New command implementation for genesis file generation |
| src/app/configurator.cpp | Updated help text to include new command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
kamilsa
approved these changes
Nov 4, 2025
xDimon
reviewed
Nov 10, 2025
| exit 2 | ||
| fi | ||
|
|
||
| # Resolve absolute paths using Python for macOS portability (realpath -f is not standard) |
Member
There was a problem hiding this comment.
You can use canonical_path + file existence check to avoid call python.
| printf " ip_addr: %s\n" "$ip" | ||
| printf " processes:\n" | ||
| printf " - path: %s\n" "$QLEAN_PATH_ABS" | ||
| printf " args: \"%s\"\n" "$(yaml_escape "$joined")" |
Member
There was a problem hiding this comment.
Better to build list of args: it mor resistant to spaces in paths and special characters
xDimon
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qlean generate-genesis (genesis-directory) (validator-count) (shadow?)command