Skip to content

Conversation

@kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Oct 1, 2025

  • README with instructions of how to build qlean
  • Examples with single node network and 4 node networks
  • shadow example

@kamilsa kamilsa requested review from turuslan and xDimon October 17, 2025 12:04
@kamilsa kamilsa marked this pull request as ready for review October 17, 2025 12:04
Copilot AI review requested due to automatic review settings October 17, 2025 12:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the README with comprehensive build instructions, example configurations, and usage documentation for the qlean blockchain node client. The PR adds detailed setup steps including dependency installation, vcpkg configuration, and CMake build process.

  • Added complete build instructions with system dependency setup for both macOS and Linux
  • Created example configurations for single-node and 4-node networks with genesis files
  • Added Shadow network simulation example with configuration files

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
README.md Complete rewrite with detailed build instructions, quick start guide, and usage examples
example/0-single/README.md Single-node network example with step-by-step instructions
example/1-network/README.md 4-validator network example with multi-node setup
shadow/README.md Shadow network simulation setup instructions
shadow/shadow.yaml Shadow configuration for 4-node network simulation
example//genesis/.yaml Genesis configuration files for validator registries, bootnodes, and network settings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

expected_final_state: running

node1:
network_node_id: 0
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nodes are configured with the same network_node_id: 0. Each node should have a unique network_node_id (0, 1, 2, 3) to properly simulate different network positions in Shadow.

Copilot uses AI. Check for mistakes.
expected_final_state: running

node2:
network_node_id: 0
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nodes are configured with the same network_node_id: 0. Each node should have a unique network_node_id (0, 1, 2, 3) to properly simulate different network positions in Shadow.

Copilot uses AI. Check for mistakes.
expected_final_state: running

node3:
network_node_id: 0
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nodes are configured with the same network_node_id: 0. Each node should have a unique network_node_id (0, 1, 2, 3) to properly simulate different network positions in Shadow.

Copilot uses AI. Check for mistakes.
Open four terminals (or run in background) and launch each node with its own key and ports.

Node 0:

Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Shell code blocks should use 'bash' instead of 'zsh' for better compatibility, as the commands shown are standard bash commands that work across different shells.

Copilot uses AI. Check for mistakes.
```

Example CLI command:

Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Shell code blocks should use 'bash' instead of 'zsh' for better compatibility, as the commands shown are standard bash commands.

Copilot uses AI. Check for mistakes.
```

### 1) Install and bootstrap vcpkg

Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Shell code blocks should use 'bash' instead of 'zsh' for better compatibility. While zsh-specific features like export commands work in bash, using 'bash' as the language identifier is more universally compatible.

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

shadow/README.md Outdated

```bash
cd /path/to/qlean-mini
sed -i "s|/path/to/qlean-mini|$(pwd)|g" shadow/shadow.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May make template shadow.yaml.in with some placeholders/variables instead of "/path/to/qlean-mini"

shadow/README.md Outdated
3) Run the example

```bash
shadow --progress true --parallelism $(nproc) shadow/shadow.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May put rm -rf shadow.data here before running shadow (may chain with &&),
instead of step "4) Cleanup"

Copy link
Member

@xDimon xDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zsh -> bash, pls

@kamilsa kamilsa enabled auto-merge (squash) October 21, 2025 09:37
@kamilsa kamilsa merged commit 190c4bf into master Oct 21, 2025
2 checks passed
@kamilsa kamilsa deleted the update/readme branch October 21, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants