add Docker support with multi-stage build #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zerg-su
commented
Oct 3, 2025
zerg-su
commented
- Add Dockerfile with 2-stage build (builder and runtime)
- Add Dockerfile.runtime for fast runtime-only rebuilds
- Update Makefile with Docker build targets (docker_build_builder, docker_build_runtime, docker_build_all)
- Install Rust via rustup in init.sh script instead of apt
- Add RUST_VERSION to .env configuration
- Update CI workflow to cache Rust via rustup
- Configure vcpkg caching with BuildKit mount
- Fix library and module paths in runtime stage
- Set --modules-dir in ENTRYPOINT for convenience
- Add Dockerfile with 2-stage build (builder and runtime) - Add Dockerfile.runtime for fast runtime-only rebuilds - Update Makefile with Docker build targets (docker_build_builder, docker_build_runtime, docker_build_all) - Install Rust via rustup in init.sh script instead of apt - Add RUST_VERSION to .env configuration - Update CI workflow to cache Rust via rustup - Configure vcpkg caching with BuildKit mount - Fix library and module paths in runtime stage - Set --modules-dir in ENTRYPOINT for convenience
added 9 commits
October 26, 2025 14:11
# Conflicts: # .ci/scripts/init.sh # Dockerfile # Makefile
- Introduced a three-stage Docker build process: dependencies, builder, and runtime. - Created Dockerfiles for each stage: Dockerfile.dependencies, Dockerfile.builder, and Dockerfile.runtime. - Updated Makefile with new targets for building and managing Docker images. - Added .dockerignore to exclude unnecessary files from Docker context. - Enhanced README and added DOCKER_BUILD.md for detailed build instructions and CI/CD integration. This structure improves build efficiency and reduces image sizes for production.
- Renamed and reorganized Makefile targets for clarity, introducing `docker_build` for fast code rebuilds and `docker_push` for pushing all images. - Updated README and DOCKER_BUILD.md to reflect new commands and usage instructions, enhancing clarity for CI/CD integration. - Improved Docker image management by consolidating push commands and cleaning up unnecessary targets. - Adjusted build times in documentation to provide accurate estimates. These changes streamline the Docker workflow and improve user experience.
- Updated Dockerfile configurations to use 'latest' tags for dependencies and builder images, improving consistency and clarity. - Optimized runtime image by stripping binaries and reducing size, resulting in a production image of approximately 240 MB. - Enhanced README and DOCKER_BUILD.md with detailed instructions on image tagging and pushing, including examples for custom and latest tags. - Improved Makefile to support flexible tagging and streamlined push commands for Docker images. These changes improve the efficiency of the Docker workflow and provide clearer guidance for users.
- Added detailed instructions for managing Docker dependencies, including tagging and pushing images with custom and latest tags. - Updated Makefile to support a default dependencies tag and improved clarity in image tagging for builder and runtime stages. - Enhanced README and DOCKER_BUILD.md to reflect new tagging strategies and best practices for dependency management. These changes improve the usability and clarity of the Docker build process for developers.
xDimon
reviewed
Nov 18, 2025
| - `qlean-mini:latest` - runtime image (~240 MB, production) | ||
|
|
||
| **When to rebuild dependencies:** | ||
| - `vcpkg.json` or `vcpkg-configuration.json` changes (new libraries) |
Member
There was a problem hiding this comment.
Should dependencies be rebuilt dew vcpkg-overlay's content changed?
| make docker_build_all | ||
|
|
||
| # AMD64 / x86_64 | ||
| make docker_build_all DOCKER_PLATFORM=linux/amd64 |
Member
There was a problem hiding this comment.
Suggested change
| make docker_build_all DOCKER_PLATFORM=linux/amd64 | |
| DOCKER_PLATFORM=linux/amd64 make docker_build_all |
| make docker_manifest_create # Create unified manifest | ||
|
|
||
| # Run on specific platform | ||
| make docker_run DOCKER_PLATFORM=linux/amd64 ARGS='--version' |
Member
There was a problem hiding this comment.
Suggested change
| make docker_run DOCKER_PLATFORM=linux/amd64 ARGS='--version' | |
| DOCKER_PLATFORM=linux/amd64 ARGS='--version' make docker_run |
| **Utility:** | ||
| ```bash | ||
| make docker_run # Run node | ||
| make docker_run ARGS='--version' |
Member
There was a problem hiding this comment.
I'm confused. Some data provided as env-vars, another as args. Please, ensure if all provides right, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.