Skip to content

Conversation

@kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Dec 2, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 2, 2025 14:50
@kamilsa kamilsa merged commit b7f7ad4 into master Dec 2, 2025
6 checks passed
@kamilsa kamilsa deleted the feature/update-example branch December 2, 2025 14:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a 4th validator node (node_3) to the example network configuration, expanding it from a 3-validator to a 4-validator devnet.

Key changes:

  • Added validator_3 configuration files (public key, node key, ENR record)
  • Updated all existing validator keys (validator_0, validator_1, validator_2) with regenerated values
  • Updated configuration files to reflect the 4-validator setup
  • Enhanced README documentation with Node 3 startup instructions

Reviewed changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
example/1-network/genesis/validators.yaml Reordered entries in reverse (node_3 to node_0) and added node_3 mapping
example/1-network/genesis/validator_3_pk.json Added public key for the new 4th validator
example/1-network/genesis/validator_2_pk.json Regenerated public key with new values
example/1-network/genesis/validator_1_pk.json Regenerated public key with new values
example/1-network/genesis/validator_0_pk.json Regenerated public key with new values
example/1-network/genesis/validator-keys-manifest.yaml Updated validator count to 4, added validator_3 entry, and updated pubkey_hex values for all validators
example/1-network/genesis/nodes.yaml Added 4th ENR record and updated existing ENR records for all nodes
example/1-network/genesis/node_3.key Added node key for the new 4th node
example/1-network/genesis/node_2.key Replaced with a new regenerated key value
example/1-network/genesis/node_1.key Replaced with a new regenerated key value
example/1-network/genesis/node_0.key Replaced with a new regenerated key value
example/1-network/genesis/config.yaml Updated validator count to 4, added validator settings section with genesis validators list, and updated genesis timestamp
example/1-network/README.md Updated title and descriptions to reflect 4-validator setup, added Node 3 startup command, and enhanced all node commands with additional flags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

GENESIS_TIME: 1764685602
# Key Settings
ACTIVE_EPOCH: 18
# Validator Settings
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace after "# Validator Settings" comment. Consider removing the trailing space for consistency.

Suggested change
# Validator Settings
# Validator Settings

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants