Feature: pruning of fork choice store #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
turuslan
reviewed
Dec 17, 2025
|
|
||
| // Safety: pull up head/safe_target up to the finalized root (just in case). | ||
| if (not blocks_.contains(head_)) { | ||
| head_ = latest_finalized_.root; |
Contributor
There was a problem hiding this comment.
Can finalized block have children? Should choose head from them?
Can use updateHead?
| head_ = latest_finalized_.root; | ||
| } | ||
| if (not blocks_.contains(safe_target_)) { | ||
| safe_target_ = latest_finalized_.root; |
Contributor
There was a problem hiding this comment.
Can use updateSafeTarget?
Comment on lines
+515
to
+516
| if (block.slot < finalized_slot) { | ||
| to_erase.push_back(hash); |
Contributor
There was a problem hiding this comment.
Do you want to remove all blocks older than finalized block?
Did you want to remove forks (traverse, maybe cache map from parent hash to children list)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.