Refactor: block tree and forck choice #51
+1,286
−748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
turuslan
approved these changes
Dec 26, 2025
| return {slot, hash()}; | ||
| } | ||
|
|
||
| BlockIndex index() const { |
Contributor
There was a problem hiding this comment.
Please choose one slotHash() or index()
| BlockHash hash; | ||
| auto operator<=>(const BlockIndex &other) const = default; | ||
|
|
||
| explicit operator Checkpoint() const { |
Contributor
There was a problem hiding this comment.
May remove explicit or use Checkpoint::from().
May add comment that the only difference between Checkpoint and BlockIndex is order (BlockIndex is sorted by slot first), or add separate wrapper for comparison (struct CheckpointOrderBySlot { Checkpoint inner; })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take to use block tree and block storage.
Extract block+state collection into block tree/storage
Implement storing of block states.
Fix logging system tuning over cli.
Some minor fixes and improvements.
remaining:
to fix fork-choice test
to refactor outcome handling (avoid exception at getting outcome-value without checks) and other ways to have exceptions.