qgswmsgetcapabilities: Use float format for min/max scale parameters #60058
+1,218
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Can we have a test that checks the truncation works ? |
Indeed! To be honest, I was convinced that there was already a unit test but I was unable to find it. I was "hoping" that one of the tests would fail! I will add one. |
ptitjano
force-pushed
the
wms-scale-denominator-format
branch
from
1c44022 to
7a3b757
Compare
I have added a unit test. |
elpaso
requested changes
Jan 8, 2025
`MinScaleDenominator` and `MaxScaleDenominator` string are created from a `QString::number` call with the default parameters. In that case, the most concise format is used. This can result in the scientific notation being used for very big or small numbers. With this change, these parameters are now always displayed in a float format. Reasons for this change: - this might prevent a loss of precision for very small or big numbers - this output is not supposed to be human readable so it does not matter if is not concise - this is the logic used by a lot of WMS servers, for example arcgis server
ptitjano
force-pushed
the
wms-scale-denominator-format
branch
from
7a3b757 to
183d1ce
Compare
elpaso
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MinScaleDenominatorandMaxScaleDenominatorstring are created from aQString::numbercall with the default parameters. In that case, the most concise format is used. This can result in the scientific notation being used for very big or small numbers.With this change, these parameters are now always displayed in a float format. Reasons for this change:
cc @troopa81