Fix boolean filtering in QGIS expressions with WFS layers #60075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR qgis#56369 introduced a regression for WFS layers, because stopping using 'false' and 'true' strings to compare with boolean fields in qgis expressions, and forcing to use the keywords false and true, it conflicted with the internal SQLite cache database of WFS layers. This PR fixes it by storing internal boolean in SQLite cache database in the right form compatible with QGIS internal functions (i.e. storing '0' and '1' strings instead of 'true' and 'false' strings).
Djedouas
changed the title
Djedouas
changed the title
Djedouas
force-pushed
the
sqlite-boolean
branch
from
15629f1 to
f7fc37a
Compare
for more information, see https://pre-commit.ci
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
JanCaha
pushed a commit
to JanCaha/QGIS
that referenced
this pull request
Jan 8, 2025
PR qgis#56369 introduced a regression for WFS layers, because stopping using 'false' and 'true' strings to compare with boolean fields in qgis expressions, and forcing to use the keywords false and true, it conflicted with the internal SQLite cache database of WFS layers. This PR fixes it by storing internal boolean in SQLite cache database in the right form compatible with QGIS internal functions (i.e. storing '0' and '1' strings instead of 'true' and 'false' strings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #56369 introduced a regression for WFS layers, because stopping using 'false' and 'true' strings to compare with boolean fields in QGIS expressions, and forcing to use the keywords
falseandtrue, it conflicted with the internal SQLite cache database of WFS layers.This PR fixes it by storing internal boolean in SQLite cache database in the right form, compatible with QGIS internal functions (i.e. storing '0' and '1' strings instead of 'true' and 'false' strings).