Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow postgresraster layers as grass processing tools input #60081

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Jan 8, 2025

Description

This is same fix as in #57958 just for Grass Processing tools.

This makes sure that that the input parameter for r.in.gdal step is properly formatted GDAL connection string even for postgresraster provider.

Funded by Ocean Winds

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 374f2a0)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 374f2a0)

Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Is there any chance you could write a test for this?

@JanCaha
Copy link
Contributor Author

JanCaha commented Jan 8, 2025

@elpaso That should not be a problem. I am just a bit unsure about the type of the test.

Would it be ok to write test file like this one: https://github.com/uclaros/QGIS/blob/e81c8a1b659cb278e852451392cb8b37134d5b84/tests/src/python/test_processing_algs_gdal_gdalutils.py
and within that file run one of the grass algorithms using:

from qgis import processing
processing.run( )

Or is something more elaborate necessary? In that case I could really use pointer to some example.

Thanks.

@elpaso
Copy link
Contributor

elpaso commented Jan 8, 2025

It's up to you, you may also have a look to the processing tests like: python/plugins/processing/tests/GdalAlgorithmsRasterTest.py and python/plugins/processing/tests/testdata/gdal_algorithm_raster_tests.yaml

@JanCaha
Copy link
Contributor Author

JanCaha commented Jan 8, 2025

Ok, tests are added .

@elpaso elpaso merged commit 1b2e33e into qgis:master Jan 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants