[server][wms] Add displayName to GFI JSON response #60343
Merged
+86
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the gray zone between a feature and a bugfix... Fixes qgis#59353
elpaso
added
Bug
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
rouault
reviewed
Jan 29, 2025
| break; | ||
| } | ||
| } | ||
| fidDisplayNameMap.insert( feature.id(), displayName ); |
There was a problem hiding this comment.
Is it possible that for a given feature displayName wouldn't be set ? If so, would we report an empty string, or nothing ? Not sure what is the desired behavior, and if that matters...
Besides that, LGTM
There was a problem hiding this comment.
I think it's possible even if probably rare, the display name comes from the evaluation of an user-defined expression.
rouault
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gray zone between a feature and a bugfix...
Fixes #59353