fix(QgsMapToolCapture): Allow snapping point with different crs#60456
Merged
nyalldawson merged 1 commit intoqgis:masterfrom Feb 6, 2025
Merged
fix(QgsMapToolCapture): Allow snapping point with different crs#60456nyalldawson merged 1 commit intoqgis:masterfrom
nyalldawson merged 1 commit intoqgis:masterfrom
Conversation
lbartoletti
added
Requires Tests!
Contributor
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
lbartoletti
force-pushed
the
fix_59792
branch
from
86d2653 to
344fe28
Compare
lbartoletti
removed
the
Requires Tests!
nyalldawson
reviewed
Feb 5, 2025
lbartoletti
force-pushed
the
fix_59792
branch
from
344fe28 to
7a0f84f
Compare
nyalldawson
approved these changes
Feb 6, 2025
Contributor
|
@lbartoletti , nice one. |
2 tasks
Member
|
Please have a look at the regression reported at #60868 which may be related with this PR. |
roya0045
reviewed
Mar 11, 2025
Comment on lines
+674
to
+677
| if ( sourceLayer->crs() != vlayer->crs() ) | ||
| { | ||
| layerPoint = toLayerCoordinates( vlayer, layerPoint ); | ||
| } |
Contributor
Member
Author
There was a problem hiding this comment.
Yes, but fixes #59792 ... When I found a for one, it's adding regression to another one...
Was AFK last days, and working on it since this morning, and sometimes I would expect that projection doesn't exist...
Anyway, I found other strange logic in QgsMapToolCapture. I hope to find a solution soon...
Member
|
Another issue report probably related to this PR: #60989. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #59792