-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CMAKE option to completely disable Python #60463
base: master
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
I'm personally +1 to an opt-in "qgis with no python", I can definitely understand the rationale behind this. (The biggest impact of this is that the build will have NO processing support 🙀 ) |
The new option should be mentioned at https://github.com/qgis/QGIS/blob/master/INSTALL.md#371-available-compilation-flags |
db6b968
to
f18411f
Compare
Co-authored-by: Even Rouault <[email protected]>
Co-authored-by: Even Rouault <[email protected]>
@lbartoletti i think you force-pushed and dropped the fixes from my earlier comments |
Description
I'm opening this PR to discuss whether we should introduce an additional layer of restriction when disabling Python in QGIS. Is the
WITH_BINDINGS
flag sufficient to completely disable Python or should be enforced?While
WITH_BINDINGS
disables PyQGIS support, if the goal is to entirely remove Python—especially for security reasons—is that enough? For example, I'm thinking about thepyplugin-installer
, which is used withQGIS_DESTKTOP
. Moreover, the CMakeLists file adds dependencies forpycore
,pygui
, andpyanalysis
, yet I can't seem to locate them.Is it necessary to include the
src/python
directory whenWITH_BINDINGS
is set to false?Any thoughts?