Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to ninja in INSTALL.md #60516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update link to ninja in INSTALL.md #60516

wants to merge 1 commit into from

Conversation

bogind
Copy link

@bogind bogind commented Feb 8, 2025

Updated windows build instructions in INSTALL.md.

Description

Previous link of ninja release was of version 1.7.2, this caused a build error on Windows (raises multiple outputs aren't (yet?) supported by depslog; which according to - Support multiple outputs in gcc depfile should be fixed in ninja version >=1.10.

Changed the link to current latest which is 1.12.1 and added a note.

Previous link was to ninja release of version 1.7.2, which caused a build error on Windows (raises multiple outputs aren't (yet?) supported by depslog;" which according to - ninja-build/ninja#1184
should be fixed in ninja version >=1.10.
Changed the link to current latest which is 1.12.1
@github-actions github-actions bot added this to the 3.42.0 milestone Feb 8, 2025
@DelazJ
Copy link
Contributor

DelazJ commented Feb 9, 2025

(For most urls there) How about, instead of directly download the binaries, we add links to the page where the download would be done, allowing people to actually see what they are about to download and make their own choice....? And these won't be outdated with new releases...

@agiudiceandrea
Copy link
Contributor

For GitHub, possible alternatives could be URLs like https://github.com/ninja-build/ninja/releases/ or https://github.com/ninja-build/ninja/releases/latest
Anyway, I think we should at least recommend the version that we know will successfully complete the build process.

@bogind
Copy link
Author

bogind commented Feb 9, 2025

The latest version (1.12.1) successfully builds.
But I agree that changing both the wording and the links to the releases page and tell them what to download.

@m-kuhn
Copy link
Member

m-kuhn commented Feb 9, 2025

I wouldn't mind dropping versions from the install.md and maintain minimum requirements in cmake where it will check all platforms. Unless we have very specific reasons for specific versions for install.md builds.

Copy link

github-actions bot commented Feb 9, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit c8953b8)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c8953b8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants