ensures that "gdal:rasterize" uses integer numbers as input to -ts parameter

[jakimowb]

Description

fixes #60524
python/plugins/processing/algs/gdal/rasterize.py

rasterize(GdalAlgorithm).getConsoleCommands(...) now ensures that values for the GDAL -ts parameter are written as int values.

[github-actions]

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 8a575a4)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 8a575a4)

[agiudiceandrea]

The previous behaviour was to use floating point values for the -ts parameter, but when the values were used by gdal_rasterize they were truncated (not rounded) internally by GDAL.
The same approach is used now to fix the issue in GDAL OSGeo/gdal#11830.
So I think that, in order to strictly maintain the same behavior, we need to truncate the values (while parameterAsInt rounds the values).
What do you think @elpaso?

[jakimowb]

@agiudiceandrea
Unfortunately, the type of WIDTH and HEIGHT QgsProcessingParameterNumber widgets cannot be changed depending on
the value of the UNIT QgsProcessingParameterEnum, to Int (UNIT=Pixels) or Float (UNIT=Georeferenced units). This would clearly show users what is expected here.
However, I wasn't aware that parameterAsDouble(..) does rounding. Now I can't think of a case where it would be better to round up instead of truncating. If specified explicitly as PIXELS, it's in responsibility of the user / calling algorithm to ensure the requested transformation to int.

[agiudiceandrea]

@jakimowb, thanks! May you add an explicit test for 'UNITS' : 0, 'WIDTH' : 100.4, 'HEIGHT': 200.6?

[elpaso]

QgsProcessingParameterNumber

Can you set Qgis::ProcessingNumberParameterType::Integer in the constructor for QgsProcessingParameterNumber ?

[agiudiceandrea]

Can you set Qgis::ProcessingNumberParameterType::Integer in the constructor for QgsProcessingParameterNumber ?

@elpaso, AFAIK it is not possible, since the HEIGHT and WIDTH algorithm's parameters are used for both the -tr option (which needs double values) and the -ts option (which needs integer values).

[jakimowb]

@elpaso as @agiudiceandrea mentioned, this is not possible. It would be an interesting new feature if QgsProcessingParameters could be switched on and off or change its configuration depending on other parameter values.

[qgis-bot]

The backport to release-3_40 failed:

The process '/usr/bin/git' failed with exit code 128

stderr

error: commit 81c553d0c9cde410290115112d163a94d9a99513 is a merge but no -m option was given.
fatal: cherry-pick failed

stdout

Auto-merging python/plugins/processing/algs/gdal/rasterize.py
[backport-60533-to-release-3_40 e8576ba88a6] ensures that "gda:rasterize" uses integer numbers as input to -ts parameter fixes #60524
 Author: Benjamin Jakimow [email protected] <[email protected]>
 Date: Mon Feb 10 16:18:07 2025 +0100
 2 files changed, 15 insertions(+), 13 deletions(-)

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60533-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fd61e5cca642c10d3f0e1966a237e912849e485a,81c553d0c9cde410290115112d163a94d9a99513,d9a1f42bd89332bf71ada66d77c859f626009909,ce0c311ba969096f7326cb5df484fe01eb58d819,8d4b6a03dfffa742f2bf1e5b6ca1a0f20f155bbf,244303f1e3064593515f379c901e7aecad150c6d,8a575a422294f054e476dcbdf055c8e1edda515a
# Push it to GitHub
git push --set-upstream origin backport-60533-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40

Then, create a pull request where the base branch is release-3_40 and the compare/head branch is backport-60533-to-release-3_40.

[agiudiceandrea]

Manual backport PR: #60564.