Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ux] In graduated and categorized symbol lists, make sure we don't append when dropping an item between other items #60546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gacarrillor
Copy link
Member

@gacarrillor gacarrillor commented Feb 11, 2025

This PR fixes an annoying and longstanding issue with drag and drop in Graduated and Categorized symbol lists.
Namely, when attempting to move an item and realizing it would end up in the last position (i.e., being appended).

BEFORE:

dragndrop_symbology_before.mp4

AFTER:

dragndrop_symbology_after.mp4

BONUS:
It also happens in Point Clouds --> Layer Styling --> Classification. This PR also fixes that one.

Fix #50823
Fix #55267
Fix #60559

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 11, 2025
@gacarrillor gacarrillor added GUI/UX Related to QGIS application GUI or User Experience Symbology Related to vector layer symbology or renderers Bug Either a bug report, or a bug fix. Let's hope for the latter! backport release-3_40 labels Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit c18f143)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c18f143)

…pend to the end when dropping an item between other items (fix qgis#50823)
… the end when dropping an item between other items (fix qgis#60559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3_40 Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience Point Clouds Symbology Related to vector layer symbology or renderers
Projects
None yet
1 participant