-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix artifacts when rendering filled line symbol #60554
Conversation
This overload avoids creating a QgsGeometry if we only have a QgsAbstractGeometry pointer object to convert
These methods directly work with GEOS geometries and avoid the forced conversions to/from QgsAbstractGeometry objects, and are intended for use in chained operations where the intermediate conversions are not required.
Use geos to calculate the buffered line instead of Qt's path stroker, as the later results in artifacts when line segments pass close to other segments Fixes qgis#59689
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I've been hit with this one before.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60554-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 97f6dc5bbe9ab74120c33f3ab4b67958604d7408,649dc29c3213a10a2e402e83386ce8fa2dc1cf76,ecf57ef9846d45278d4c4c24fbd4e0dd93ed9b6a,f0110d6d0f1ef77f450ddc5210f6f8e71ac808f5
# Push it to GitHub
git push --set-upstream origin backport-60554-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40 Then, create a pull request where the |
Use geos to calculate the buffered line instead of Qt's path stroker,
as the later results in artifacts when line segments pass close
to other segments
Fixes #59689