-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverity fixes #60555
Coverity fixes #60555
Conversation
The warning is a false positive, since we were already checking that the optional has a value before accessing it. But we can avoid the exception altogether (and gain some performance) by using the std::optional dereference operator, which DOES not throw and which relies on the previous has_value check to avoid undefined behavior.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_40 release-3_40
# Navigate to the new working tree
cd .worktrees/backport-release-3_40
# Create a new branch
git switch --create backport-60555-to-release-3_40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 73525ed182aea6926c6a32a33fb4b091c8cc0331,bcdedb4fcf4387e317d1eb173de8ff6946e48281,8f170a683075285a58aa49956c633221ac56566f,e3762c5f6e46b408f4a06319734bbcb6e4fcf111
# Push it to GitHub
git push --set-upstream origin backport-60555-to-release-3_40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_40 Then, create a pull request where the |
No description provided.