Rework layer "Execute SQL" action to use non-modal dialog #60820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the "Execute SQL" command is executed through the browser, then the window is opened as a non-modal QMainWindow. If however the same command was used via the layer right-click menu, the dialog would open as a blocking modal dialog. Rework the layer right-click version to also use a non-modal QMainWindow, and ensure that no references to the layer instance are required in the connected slots
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
approved these changes
Mar 3, 2025
| std::unique_ptr<QgsAbstractDatabaseProviderConnection> conn2 { QgsMapLayerUtils::databaseConnection( layer ) }; | ||
| if ( conn2 ) | ||
| { | ||
| QAction *executeSqlAction = new QAction( QgsApplication::getThemeIcon( QStringLiteral( "/dbmanager.svg" ) ), tr( "Execute SQL…" ), menu ); |
There was a problem hiding this comment.
TODO one day, copy/rename that icon to be slightly more generic than referring to DB Manager as we move forward to phasing that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "Execute SQL" command is executed through the browser, then the window is opened as a non-modal QMainWindow. If however the same command was used via the layer right-click menu, the dialog would open as a blocking modal dialog.
Rework the layer right-click version to also use a non-modal QMainWindow, and ensure that no references to the layer instance are required in the connected slots