Skip to content

New tools for Points Clouds from PDAL Wrench 1.3.0 #64343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JanCaha wants to merge 7 commits into
base: master
Choose a base branch
from
Open

New tools for Points Clouds from PDAL Wrench 1.3.0 #64343

JanCaha wants to merge 7 commits into from
+1,213 −0

Conversation

@JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Dec 18, 2025

Description

Recent update to PDAL Wrench in #64303 brought several new tools. This adds QGIS Algorithms for the new tools.

New tools:

  • Classify Ground Points
  • Filter Noise (by radius algorithm)
  • Filter Noise (by statistical algorithm)
  • Height Above Ground (by Delaunay)
  • Height Above Ground (by Nearest Neighbour)
  • Transform coordinates of point cloud

@github-actions github-actions bot added this to the 4.0.0 milestone Dec 18, 2025
alexbruy
alexbruy reviewed Dec 18, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 2, 2026
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 5, 2026
@JanCaha JanCaha marked this pull request as ready for review January 5, 2026 08:15
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026 •
edited
Loading

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 4b672a7)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit 4b672a7)

DelazJ
DelazJ reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JanCaha
Just reminding some formatting rules.

src/analysis/processing/pdal/qgsalgorithmpdalclassifyground.cpp Outdated
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "SCALAR" ), QObject::tr( "Scalar" ), Qgis::ProcessingNumberParameterType::Double, 1.25 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "SLOPE" ), QObject::tr( "Slope" ), Qgis::ProcessingNumberParameterType::Double, 0.15 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "THRESHOLD" ), QObject::tr( "Threshold" ), Qgis::ProcessingNumberParameterType::Double, 0.5 ) );
addParameter( new QgsProcessingParameterNumber( QStringLiteral( "WINDOW_SIZE" ), QObject::tr( "Window size" ), Qgis::ProcessingNumberParameterType::Double, 18.0 ) );
Copy link
Contributor

@DelazJ DelazJ Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this label (and maybe some above) be more verbose, i.e., "Maximum filter window size"?

Copy link
Contributor Author

@JanCaha JanCaha Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors parameters names in PDAL and PDAL Wrench, I would oppose changing the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexbruy alexbruy alexbruy left review comments

+1 more reviewer

@DelazJ DelazJ DelazJ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JanCaha @alexbruy @DelazJ