-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Backport release-3_44] PDAL Wrench version 1.3.0 #64345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-3_44
Are you sure you want to change the base?
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
|
@agiudiceandrea It is also strange because those tests passed for original PR (here. I dont see a way why those should fail here, also there is no reason for those test to behave differently in 5 and 6. Would you mind reruning those tests? |
|
@JanCaha, thanks for looking at this. Anyway the tests TestQgsProcessingPdalAlgs::clip(), TestQgsProcessingPdalAlgs::merge(), TestQgsProcessingPdalAlgs::reproject(), in "Run tests (6, ALL_BUT_PROVIDERS)", still fail: https://github.com/qgis/QGIS/actions/runs/20693664537/job/59408847511?pr=64345#step:13:1063.
It may be due to the fact that the tests for release-3_44 branch are run on Fedora 39 with PDAL 2.5.6, while for master branch the tests are run on Fedora 42 with PDAL 2.8.4. |
|
@agiudiceandrea Ah, I did not realize that, I have been working with latest PDAL. That could be a reason. I kind of was not happy with this being backported, as this is a new version of WRENCH not just fixes. A lot of things changed and were updated from previous version. So I was worried that something like this might happen. I know that there was specific problem that you wanted to address with that, but maybe only that fix could be backported? |
Backport #64303
Authored by: @JanCaha