Skip to content

Conversation

@ViperMiniQ
Copy link
Contributor

@ViperMiniQ ViperMiniQ commented Dec 18, 2025

This PR adds a slider that controls the point of switching between rendering overview only and rendering a sub index of the VPC.

The slider is more aggressive going to the right, less aggressive going to the left.

On 2D map canvas, if the average extent width of the sub indexes multiplied by the value from the slider is higher than the viewable map canvas, a sub index is loaded, otherwise overview only gets rendered.

Similarly, in the 3D Map, multiplier is applied on the sub index bounding box and if the camera is located within the box, sub index is fully loaded and rendered, if the camera is outside the box, overview only is rendered.

One change is that when all the sub indexes are shown in the 3D Map, we disable overview rendering to save resources.

2d overview rendering

3d vpc overview

@github-actions github-actions bot added this to the 4.0.0 milestone Dec 18, 2025
@github-actions
Copy link
Contributor

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)

One or more tests failed using the build from commit a9eb485

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@github-actions
Copy link
Contributor

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - fedora)

One or more tests failed using the build from commit a9eb485

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit fad63e4)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit fad63e4)

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 3, 2026
@wonder-sk wonder-sk removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 7, 2026
@qgis qgis deleted a comment from github-actions bot Jan 7, 2026
slider holds values with which the sub index extent/3d bounding box is mutliplied by and depending on the map canvas containing the extent or camera being within the scaled bounding box, we render the full sub index or just the overview
@ViperMiniQ ViperMiniQ force-pushed the vpc-overview-loading-distance branch from 8657483 to e68fb10 Compare January 7, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants