[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351

ViperMiniQ · 2025-12-18T15:03:19Z

This PR adds a slider that controls the point of switching between rendering overview only and rendering a sub index of the VPC.

The slider is more aggressive going to the right, less aggressive going to the left.

On 2D map canvas, if the average extent width of the sub indexes multiplied by the value from the slider is higher than the viewable map canvas, a sub index is loaded, otherwise overview only gets rendered.

Similarly, in the 3D Map, multiplier is applied on the sub index bounding box and if the camera is located within the box, sub index is fully loaded and rendered, if the camera is outside the box, overview only is rendered.

One change is that when all the sub indexes are shown in the 3D Map, we disable overview rendering to save resources.

github-actions · 2025-12-18T17:44:47Z

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)

One or more tests failed using the build from commit a9eb485

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619

Rendered image did not match tests/testdata/control_images/3d/expected_virtual_pointcloud_3d_overview/default/expected_virtual_pointcloud_3d_overview.png (found 745 pixels different)
Rendered image did not match tests/testdata/control_images/3d/expected_virtual_pointcloud_3d_overview/qt6/expected_virtual_pointcloud_3d_overview.png (found 745 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

github-actions · 2025-12-18T17:44:49Z

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - fedora)

One or more tests failed using the build from commit a9eb485

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Test failed at testPointCloud3DOverview at tests/src/3d/testqgspointcloud3drendering.cpp:619

Rendered image did not match tests/testdata/control_images/3d/expected_virtual_pointcloud_3d_overview/default/expected_virtual_pointcloud_3d_overview.png (found 745 pixels different)
Rendered image did not match tests/testdata/control_images/3d/expected_virtual_pointcloud_3d_overview/qt6/expected_virtual_pointcloud_3d_overview.png (found 745 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

github-actions · 2025-12-18T19:46:05Z

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c1369c3)

🍎 MacOS Qt6 builds

Download MacOS Qt6 builds of this PR for testing.
This installer is not signed, control+click > open the app to avoid the warning
(Built from commit c1369c3)

slider holds values with which the sub index extent/3d bounding box is mutliplied by and depending on the map canvas containing the extent or camera being within the scaled bounding box, we render the full sub index or just the overview

rename zoomOutMultiplier to overviewSwitchingScale

tests/src/3d/testqgspointcloud3drendering.cpp

uclaros · 2026-01-22T14:14:08Z

src/ui/3d/qgspointcloud3dsymbolwidget.ui

+          <widget class="QComboBox" name="mZoomOutOptions"/>
+         </item>
+         <item row="1" column="1" colspan="2">
+          <widget class="QComboBox" name="mOverviewSwitchingScale"/>


Can you add a tooltip for the combo box?
Something along the lines:

Sets the zoom level at which the individual point cloud files will get rendered instead of the overview or their extents.\n Normal means roughly when the point cloud extent no longer fits the map extent.\n Select Earlier to switch at a smaller scale (zoomed out) or Later to switch at a larger scale (zoomed in).

uclaros · 2026-01-22T14:17:19Z

src/3d/qgspointcloudlayer3drenderer.h

    Qgis::PointCloudZoomOutRenderBehavior zoomOutBehavior() const { return mZoomOutBehavior; }

+    /**
+      * Sets the overview switching scale


Can you expand the two docstrings to explain the effect it has / how it works?

uclaros · 2026-01-22T14:19:56Z

src/core/pointcloud/qgspointcloudrenderer.h

@@ -712,6 +712,18 @@ class CORE_EXPORT QgsPointCloudRenderer
     */
    Qgis::PointCloudZoomOutRenderBehavior zoomOutBehavior() const { return mZoomOutBehavior; }

+    /**
+      * Sets the overview switching scale
+      * \since QGIS 4.0


Same for these

uclaros · 2026-01-22T14:21:49Z

src/gui/pointcloud/qgspointcloudrendererpropertieswidget.h

@@ -64,7 +64,16 @@ class GUI_EXPORT QgsPointCloudRendererPropertiesWidget : public QgsMapLayerConfi
    void emitWidgetChanged();

  private:
+    const QMap<double, QString> mOverviewSwitchingScaleMap {


Can you add a comment that we have a similar setting for 3D in QgsPointCloud3DSymbolWidget, so we update them in parallel? (also a comment in QgsPointCloud3DSymbolWidget pointing here too)

…ng and pc loading

uclaros

Thanks, looks good now!

qgis-bot · 2026-01-26T07:26:37Z

@ViperMiniQ
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

qgis-bot · 2026-01-26T07:26:39Z

@ViperMiniQ

This pull request has been tagged for the changelog.

The description will be harvested so please provide a "nearly-ready" text for the final changelog
If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits

Funded by NAME
Funded by URL
Funded by NAME URL
Sponsored by NAME
Sponsored by URL
Sponsored by NAME URL

Thank you!

github-actions bot added this to the 4.0.0 milestone Dec 18, 2025

github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 3, 2026

wonder-sk removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 7, 2026

qgis deleted a comment from github-actions bot Jan 7, 2026

ViperMiniQ added 3 commits January 7, 2026 10:46

adjust label text

317f9fc

update test, misc fixes, add another value to array

e68fb10

ViperMiniQ force-pushed the vpc-overview-loading-distance branch from 8657483 to e68fb10 Compare January 7, 2026 09:47

ViperMiniQ added 2 commits January 8, 2026 10:06

fix strings

fad63e4

change from slider to combobox

1c05c44

rename zoomOutMultiplier to overviewSwitchingScale

ViperMiniQ changed the title ~~[Virtual Point Clouds] Add slider to adjust the switching between rendering overview only and sub index rendering~~ [Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering Jan 12, 2026

ViperMiniQ closed this Jan 12, 2026

ViperMiniQ reopened this Jan 12, 2026

uclaros reviewed Jan 22, 2026

View reviewed changes

ViperMiniQ added 4 commits January 22, 2026 17:06

fix overview not rendering when subindexes are not loaded

ba681ed

use screen space error to decide switching between the overview loadi…

c6f2d01

…ng and pc loading

add toolips and detaild docs

5d858a7

fix clang tidy warning

c1369c3

uclaros approved these changes Jan 26, 2026

View reviewed changes

uclaros added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jan 26, 2026

uclaros added the Point Clouds label Jan 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351

[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351

ViperMiniQ commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

uclaros Jan 22, 2026

Uh oh!

uclaros Jan 22, 2026

Uh oh!

uclaros Jan 22, 2026

Uh oh!

uclaros Jan 22, 2026

Uh oh!

uclaros left a comment

Uh oh!

qgis-bot commented Jan 26, 2026

Uh oh!

qgis-bot commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351

Are you sure you want to change the base?

[Virtual Point Clouds] Add combobox to adjust the switching between rendering overview only and sub index rendering #64351

Conversation

ViperMiniQ commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - ubuntu)

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Uh oh!

github-actions bot commented Dec 18, 2025

Tests failed for Qt 6 (ALL_BUT_PROVIDERS - fedora)

virtual_pointcloud_3d_overview (testPointCloud3DOverview)

virtual_pointcloud_3d_overview

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🪟 Windows Qt6 builds

🍎 MacOS Qt6 builds

Uh oh!

Uh oh!

uclaros Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

uclaros Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

uclaros Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

uclaros Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

uclaros left a comment

Choose a reason for hiding this comment

Uh oh!

qgis-bot commented Jan 26, 2026

Uh oh!

qgis-bot commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ViperMiniQ commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading