Add digitizing support for TIN and PolyhedralSurface geometries #64354
+541
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
rouault
reviewed
Dec 20, 2025
ptitjano
reviewed
Dec 22, 2025
lbartoletti
force-pushed
the
fix/phs_tin
branch
from
c05a0c8 to
f49cb5c
Compare
lbartoletti
force-pushed
the
fix/phs_tin
branch
from
f49cb5c to
f474be6
Compare
ptitjano
reviewed
Jan 2, 2026
| newGeom = QgsGeometry( std::move( polySurface ) ); | ||
| } | ||
|
|
||
| // PolyhedralSurface/TIN to (Multi)Polygon |
Collaborator
There was a problem hiding this comment.
Add this conversion in the documentation of the function please.
| newGeom = QgsGeometry( std::move( polySurface ) ); | ||
| } | ||
|
|
||
| //(Multi)Polygon/Triangle to TIN |
nyalldawson
reviewed
Jan 8, 2026
| QProgressDialog progress( tr( "Collecting patches…" ), tr( "Abort" ), 0, featureList.size(), this ); | ||
| progress.setWindowModality( Qt::WindowModal ); | ||
|
|
||
| QApplication::setOverrideCursor( Qt::WaitCursor ); |
Collaborator
There was a problem hiding this comment.
Use QgsTemporaryCursorOverride instead
|
|
||
| QApplication::setOverrideCursor( Qt::WaitCursor ); | ||
|
|
||
| auto resultTin = std::make_unique<QgsTriangulatedSurface>(); |
Collaborator
There was a problem hiding this comment.
Can this logic be moved out of the mammoth QgisApp class? (Eg maybe to QgsAppMapTools?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds initial digitizing support for TIN (Triangulated Irregular Network) and PolyhedralSurface geometry types.
These geometry types can now be edited using existing digitizing tools:
Notes
This is a first step toward full digitizing support for these geometry types. The current implementation adapts existing digitizing tools to respect the constraints of TIN and PolyhedralSurface geometries (but not "surface" since it's not yet well supported)
(e.g., TIN patches must be triangles, surfaces can hold multiple patches without requiring a "Multi" type).
Further digitizing improvements may be added in future versions.
Sponsored by Stadt Frankfurt am Main / Oslandia