Unaccent layers, bookmarks, actions, layouts and settings in locator and processing toolbox search #64436
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always perform unaccent to both the layer name and search term. This allows users to find layers regardless of accents - for example, searching for "creme" will match a layer named "crème", and vice versa.
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
Makes the Settings and Actions locator filters always perform accent-insensitive matching by applying QgsStringUtils::unaccent() to both the item name and search term before scoring. E.g. searching for "parametres" will match "Paramètres généraux".
tudorbarascu
changed the title
Member
|
Does it fix #39475 ? |
Member
Author
Partially, as it does fix the unaccent for the locator search bar. I haven't looked at the processing search yet. |
tudorbarascu
changed the title
Member
Author
|
@nicogodet It does fix it now. |
tudorbarascu
force-pushed
the
unaccent_locator
branch
from
a8f8fde to
e64f0d0
Compare
fixes qgis#39475 This resolves the issue where searching for "selection" would not match algorithms named "Sélection par localisation" and similar cases with accented characters.
Member
Nice! |
tudorbarascu
force-pushed
the
unaccent_locator
branch
from
e64f0d0 to
cc72b2e
Compare
Member
Author
|
Thanks @lbartoletti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the unaccent function to improve locator and search more easily for layer names, layouts and bookmarks.
Unaccent also now works for the search in the processing toolbox.
E.g. from now on if a user searches for "creme" the locator will match a layer named "crème", and vice versa.
I tested all by hand (except the locator actions filter as I got lazy). Sometimes the CI fails but unrelated. I don't know if the processing toolbox search should have come in another pull request, I just added it here.
Fixes #39475