disable unity build for server on msvc #64440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
m-kuhn
reviewed
Jan 5, 2026
| target_precompile_headers(qgis_server PRIVATE $<$<COMPILE_LANGUAGE:CXX>:${CMAKE_SOURCE_DIR}/src/core/qgis.h>) | ||
| endif() | ||
|
|
||
| if(NOT MSVC) |
Member
There was a problem hiding this comment.
@jef-n could you add a comment why this is disabled for MSVC (error message or at least a reference to OSGEO4W)?
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Suggested change
| if(NOT MSVC) | |
| if(NOT MSVC) # error C2664: 'wint_t ungetwc(wint_t,FILE *)': cannot convert argument 2 from 'FCGI_FILE *' to 'FILE *' https://cdash.orfeo-toolbox.org/viewBuildError.php?buildid=37453 |
jef-n
added a commit
to jef-n/OSGeo4W
that referenced
this pull request
Jan 5, 2026
jef-n
force-pushed
the
msvc-disable-unity-build-of-server
branch
from
d541a06 to
93834db
Compare
m-kuhn
approved these changes
Jan 5, 2026
jef-n
added a commit
to jef-n/OSGeo4W
that referenced
this pull request
Jan 5, 2026
This reverts commit 507376a with upstreamed patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switched osgeo4w nightly to unity builds, because #64395 broke it - but server fails in a unity build