Fix browser tooltip refresh for table comments #64441
Open
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update QgsDataItem::refresh() to copy tooltips from new items to existing items - Add RefreshChildrenWhenItemIsRefreshed capability to PostgreSQL and HANA schema items - Enables proper refresh of table comments at both connection and schema levels
Collaborator
|
This is not quite the right approach -- you should instead update the "equals" methods for the item subclass which isn't being correctly updated to consider the tooltip too |
Contributor
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
Collaborator
|
@TimMcCauley lgtm! Can you confirm this new approach fixes the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug described in #64414
What now works
PostgreSQL: Refresh connection → table comments update
PostgreSQL: Refresh schema → table comments update
SAP HANA: Refresh connection → table comments update
SAP HANA: Refresh schema → table comments update
Possible improvements