Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 17[xml] #207

Merged
merged 3 commits into from
Jul 30, 2023
Merged

support 17[xml] #207

merged 3 commits into from
Jul 30, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Jul 28, 2023

XML is supported in C++17, and its performance remains almost the same as before.

@bbbgan
Copy link
Collaborator Author

bbbgan commented Jul 28, 2023

image
from left to right, it is: current repository, C++20 of PR , C++17 of PR.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 68.18% and project coverage change: +0.11% 🎉

Comparison is base (f0d77cf) 43.58% compared to head (fb6baba) 43.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   43.58%   43.70%   +0.11%     
==========================================
  Files          45       45              
  Lines        5337     5343       +6     
==========================================
+ Hits         2326     2335       +9     
+ Misses       3011     3008       -3     
Files Changed Coverage Δ
iguana/json_util.hpp 20.00% <ø> (ø)
iguana/xml_reader.hpp 33.33% <0.00%> (ø)
iguana/xml_util.hpp 46.15% <0.00%> (+4.97%) ⬆️
iguana/xml_writer.hpp 91.66% <0.00%> (-2.46%) ⬇️
test/test_xml.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qicosmos qicosmos merged commit 4f81eeb into qicosmos:master Jul 30, 2023
18 checks passed
171930433 pushed a commit to 171930433/iguana that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants