improve [struct_pb] #257
Merged
improve [struct_pb] #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbbgan
commented
Apr 26, 2024
iguana/struct_pb.hpp
Outdated
| @@ -221,10 +223,10 @@ inline void from_pb_impl(T& val, std::string_view& pb_str, uint32_t field_no) { | |||
| if constexpr (is_reflection_v<value_type>) { | |||
| size_t pos; | |||
| uint32_t size = detail::decode_varint(pb_str, pos); | |||
| pb_str = pb_str.substr(pos); | |||
There was a problem hiding this comment.
bug，应该先移动再判断，判断剩余的字符串的大小和size之间的关系。剩下有几处也类似
bbbgan
commented
Apr 26, 2024
iguana/struct_pb.hpp
Outdated
| } | ||
| else { | ||
| detail::encode_fixed_field(field_no, WireType::Fixed32, (uint32_t)(val), | ||
| out); | ||
| detail::encode_fixed_field(field_no, WireType::Fixed32, val, out); |
There was a problem hiding this comment.
这里应该不需要强制转换吧，在处理double类型会出现问题，我认为没有强制转换的必要，所以我删除了。
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## struct_pb #257 +/- ##
=============================================
+ Coverage 45.08% 48.37% +3.29%
=============================================
Files 46 51 +5
Lines 5638 6135 +497
=============================================
+ Hits 2542 2968 +426
- Misses 3096 3167 +71 ☔ View full report in Codecov by Sentry. |
bbbgan
force-pushed
the
struct_pb
branch
3 times, most recently
from
b237bfb
to
6c2a2e4
Compare
qicosmos
reviewed
May 9, 2024
iguana/reflection.hpp
Outdated
| get_members_impl(t), 1, std::make_index_sequence<Size>{}); | ||
| return map; | ||
| using Tuple = decltype(reflect_members::apply_impl()); | ||
| constexpr size_t TypeSize = tuple_type_count<Tuple>(); |
There was a problem hiding this comment.
tuple_type_count 这个方法是多余的。有两种方法获取tuple的size，第一种:
constexpr size_t Size = reflect_members::value();第二种：
std::tuple_size_v<Tuple>
iguana/reflection.hpp
Outdated
Comment on lines
838
to
839
| constexpr auto offset_arr = get_offset_arr<sizeof...(I), T>(); | ||
| constexpr auto remap_arr = get_remap_arr(offset_arr); |
iguana/reflection.hpp
Outdated
Comment on lines
793
to
795
| constexpr auto type_options_arr = | ||
| get_type_options_arr<Tuple>(std::make_index_sequence<Size>{}); | ||
| return get_field_tuple_impl( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.