sync to yalanting libs #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbbgan
reviewed
Jun 25, 2024
iguana/dynamic.hpp
Outdated
Comment on lines
116
to
129
| std::vector<std::string_view> get_fields_name() const override { | ||
| static constexpr auto map = iguana::get_members<T>(); | ||
|
|
||
| std::vector<std::string_view> vec; | ||
| for (auto [no, val] : map) { | ||
| std::set<std::string_view> sets; | ||
|
|
||
| for (auto const& [no, val] : map) { | ||
| std::visit( | ||
| [&](auto& field) { | ||
| vec.push_back(std::string_view(field.field_name.data(), | ||
| field.field_name.size())); | ||
| [&](auto const& field) { | ||
| if (auto it = sets.emplace(field.field_name.data(), | ||
| field.field_name.size()); | ||
| it.second) { | ||
| vec.push_back(*it.first); | ||
| } |
There was a problem hiding this comment.
variant造成重复应该是相邻的吧，直接判断和上一个是否一样就行了，不需要set，可以简化一下！
bbbgan
reviewed
Jun 26, 2024
iguana/dynamic.hpp
Outdated
| [&](auto const& field) { | ||
| std::string_view const current_name{field.field_name.data(), | ||
| field.field_name.size()}; | ||
| if (vec.empty() || (!vec.empty() && (vec.back() != current_name))) { |
There was a problem hiding this comment.
这里可以稍微简化一下，
if (vec.empty() || (vec.back() != current_name))因为判断vec.back()的时候前面的vec.empty()一定是false，否则为true不会执行vec.back()
bbbgan
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.