Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fontawesome icons for media keys #1381

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

fauxpark
Copy link
Member

Description

image

@fauxpark fauxpark requested a review from a team December 20, 2024 02:11
Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable. Any comments @noroadsleft ?

@yanfali yanfali requested a review from noroadsleft December 20, 2024 03:46
@fauxpark
Copy link
Member Author

@yanfali this good to go in?

@yanfali
Copy link
Collaborator

yanfali commented Jan 10, 2025

sure. merge it.

@fauxpark fauxpark merged commit ea4e23d into qmk:master Jan 10, 2025
2 checks passed
@fauxpark fauxpark deleted the media-keys-fontawesome branch January 10, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants