Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some keycode picker labels #1383

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Improve some keycode picker labels #1383

merged 3 commits into from
Jan 14, 2025
+81 −81

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 21, 2024 •
edited
Loading

Description

  • Added ↵ symbol to KC_ENT to distinguish it from the numpad enter
  • KC_APP label is now ≡, matching the FA icon used in the keymap view
  • Changed GUI key labels from OS to GUI for consistency
  • Arrow keys and mousekey cursor/wheel directions show actual arrows (technically Unicode triangles)
  • Changed lighting & volume keycodes to also use triangles to indicate function
  • Adjusted modifier swapping labels to use ⇄ and tweaked for consistency
  • Added numlock labels for numpad keys

image
image
image

@fauxpark fauxpark requested a review from a team December 21, 2024 06:22
@fauxpark
Copy link
Member Author

@yanfali thoughts on this one too?

After this I can actually get started bringing the keycode names up to date. All the lighting keycodes are getting their own tab.

yanfali
yanfali approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fauxpark fauxpark merged commit 8bd66b0 into qmk:master Jan 14, 2025
2 checks passed
@fauxpark fauxpark deleted the keycode-picker-labels branch January 14, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanfali yanfali yanfali approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @yanfali