Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fontawesome icon for key delete button #1389

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 6, 2025

Description

image

@fauxpark fauxpark requested a review from a team January 6, 2025 05:46
@yanfali
Copy link
Collaborator

yanfali commented Jan 6, 2025

Please add screenshots of the other key types too. Otherwise seems reasonable.

@fauxpark
Copy link
Member Author

fauxpark commented Jan 6, 2025

Sure thing
image
(hover state disabled for demo)

Copy link
Collaborator

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fauxpark fauxpark merged commit 38be222 into qmk:master Jan 6, 2025
2 checks passed
@fauxpark fauxpark deleted the key-delete-button-icon branch January 6, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants