Adding Ploopyco functions so Host State Control can be implemented for Ploopy Nano #23953
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Functionality is opt-in via PLOOPY_HOST_LED_CONTROL - Pressing Num lock cycles DPI - Pressing Scroll lock enables Drag Scroll - Enters bootloader when Num, Caps, and Scroll lock are on at the same time - Updated documentation
- Removed Host State control code from keyboard level - Will leave it up to the user to implement it at the user level
t4corun
changed the title
|
Revised PR based on @obosob's Discord comment. Removed keyboard level Host State control. Leave it to the user to implement it at the keymap. Tested on my Ploopy Nano. The previous commit still has the Host state control if that is still desired. |
drashna
approved these changes
Jun 19, 2024
Agree with obosob. This is something best left implemented at the user level. However the helper functions are a good idea and useful. |
|
Thanks, but credit to @obosob for the idea. I was originally trying to call the ploopyco DRAG_SCROLL from my other QMK boards and was struggling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed gap in Ploopy Nano where drag scroll and dpi cannot be accessed at the userspace level. User can now implement Host State Control in their keymap
Description
Extends on the current code base. Drag scroll variable and dpi cycling logic moved into functions so they can be called at the userspace level.
Types of Changes
Issues Fixed or Closed by This PR
N/A
Checklist