[Keyboard] Add/Update Pimoroni keybow 2040 #23986
Open
+240
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
zvecr
requested changes
Jun 23, 2024
willoucom
force-pushed
the
pimoroni_keybow_2040
branch
2 times, most recently
from
e7d50a0
to
1396152
Compare
|
Hello @zvecr |
zvecr
requested changes
Jun 23, 2024
willoucom
force-pushed
the
pimoroni_keybow_2040
branch
from
7e13f35
to
f322d39
Compare
Rename info.json to keyboard.json Update keyboards/pimoroni/keybow2040/readme.md Update keyboards/pimoroni/keybow2040/readme.md Update keyboards/pimoroni/keybow2040/mcuconf.h Update keyboards/pimoroni/keybow2040/info.json Update keyboards/pimoroni/keybow2040/config.h Delete rules.mk Update keyboards/pimoroni/keybow2040/keybow2040.c Update keyboards/pimoroni/keybow2040/keyboard.json Update keyboards/pimoroni/keybow2040/config.h Co-Authored-By: Joel Challis <[email protected]>
No problem |
drashna
reviewed
Jun 24, 2024
| #define I2C_DRIVER I2CD0 | ||
| #define I2C1_SDA_PIN GP4 | ||
| #define I2C1_SCL_PIN GP5 | ||
| #define I2C1_CLOCK_SPEED 100000 |
There was a problem hiding this comment.
Only 100kHz? I know the 3731 can handle 400kHz.
drashna
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to try to continue the work done on #21481
I am not the original author of the firmware.
Description
This is a continuation, I tries to update files according to the last unresolved request changes.
Types of Changes
Checklist