Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'qmk new-keyboard' processing of development_board #23996

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 25, 2024

Description

Config would be created without the "board" config, which for blackpills fails to configure its HSE frequency correctly.

Instead of expanding development_board to its relevant config , just use the setting directly.

Also fixes the case of qmk import-keyboard where the json file is using development_board. Previously it would have processor/bootloader keys with unresolved tokens.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Jun 25, 2024
@github-actions github-actions bot added python cli qmk cli command labels Jun 25, 2024
@zvecr zvecr merged commit 3ffe8d9 into master Jun 30, 2024
5 checks passed
@zvecr zvecr deleted the fix_new_kb_dev_board branch June 30, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants