Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Add configuration for build time dependencies #146

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

EdmundGoodman
Copy link

@EdmundGoodman EdmundGoodman commented Jul 25, 2023

Resolves #145.

In accordance with https://peps.python.org/pep-0517/ , the build time dependency NumPy should be specified, as otherwise QML cannot be installed unless NumPy is already installed on the system, which breaks installation in fresh virtual environments.

This change specifies the build time dependency, and so should fix the issue. Once it is released, the following commands should run without error:

python3 -m venv venv
source venv/bin/activate
pip install qml

@EdmundGoodman
Copy link
Author

EdmundGoodman commented Jul 25, 2023

It is also worth noting as shown in the warning message in #143 that numpy.distutils as used in setup.py is deprecated and should be migrated away from (https://numpy.org/devdocs/reference/distutils_status_migration.html). However, this is a bigger change which should be done in a separate pull request

       `numpy.distutils` is deprecated since NumPy 1.23.0, as a result
       of the deprecation of `distutils` itself. It will be removed for
       Python >= 3.12. For older Python versions it will remain present.
       It is recommended to use `setuptools < 60.0` for those Python versions.
       For more details, see:
         https://numpy.org/devdocs/reference/distutils_status_migration.html```

@charnley
Copy link
Member

charnley commented Dec 8, 2024

Please note that further development for the QML package is now happening on the qmlcode/qmllib repository. qmllib is a port of the QML's Fortran core functionality with fewer dependencies and numpy 2.0 compatibility. You are encouraged to open any future issues or pull requests there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants