Skip to content

Conversation

akirakyle
Copy link
Member

@akirakyle akirakyle commented Nov 25, 2024

This PR implements the proposal in #26 and thus would close #25 and #26. I've also marked all remaining offending instances of #12 as FIXME for now as I think resolving those should be kept separate from this PR.

The remaining TODOs for this PR are then

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 17.04%. Comparing base (3d63b38) to head (8a5aa31).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/julia_base.jl 0.00% 12 Missing ⚠️
src/bases.jl 0.00% 9 Missing ⚠️
src/expect_variance.jl 0.00% 8 Missing ⚠️
src/linalg.jl 0.00% 8 Missing ⚠️
src/abstract_types.jl 0.00% 6 Missing ⚠️
src/identityoperator.jl 0.00% 4 Missing ⚠️
src/julia_linalg.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   17.29%   17.04%   -0.26%     
==========================================
  Files          12       12              
  Lines         399      399              
==========================================
- Hits           69       68       -1     
- Misses        330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krastanov
Copy link
Member

@apkille , just a heads up that this is happening and it might lightly affect Gabs.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samebases(::AbstractOperator, ...) should use calls to basis instead of assuming internal layout for the structures
2 participants