Throw specific errors for 'external_account' type#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub ActionsからIDフェデレーションした際などに入手できるクレデンシャルは
"type": "external_account"となっている。これはまだサポートされおらず、実装するのは結構大変そう。
↓ 実装が3つに分岐してる上に中でもさらに色々枝分かれてしていて複雑。
https://github.com/googleapis/google-cloud-node-core/blob/101091260776be70b52ed6277f2cd74bae3bf4be/packages/google-auth-library-nodejs/src/auth/externalclient.ts#L78-L84
とりあえず専用のエラーを出して、サポートできていないことを明確に伝える。
そのほか、エラーの見え方が悪かったりした部分の細かい修正。