-
Notifications
You must be signed in to change notification settings - Fork 8
Exporting SetFailCodeFlash/SetNoticeFlash #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| // if r.Method == http.MethodGet { | ||
| b.setContinueURL(w, r) | ||
| } | ||
| // } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Method Handling Causes Login Redirection Issues
The if r.Method == http.MethodGet check was commented out, causing setContinueURL to be called for all HTTP methods. This saves non-GET requests (like form submissions) as continue URLs. After login, users are redirected to these action endpoints, which can lead to "Method Not Allowed" errors or lost form data, disrupting the user flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| web.Page(b.loginCodePageFunc).ServeHTTP(w, r) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Login Flow Broken: Account Lost
After sending the login code, sendUserCodeLogin serves the login code page directly without passing the account parameter. The login code validation page expects account in the URL query string to populate a hidden form field, but it's only available in the POST form values. This causes the account to be lost when the user submits the login code, breaking the login flow.
… pnpm version fix: add decimal separator support in VXField.vue build: configure Vite to disable minification and change entry file name chore: add generated vuetifyx.js to distribution
Those functions are useful when you have custom forms
Note
Export
SetFailCodeFlashandSetNoticeFlash, update related login modules, and rebuildvuetifyxassets.SetFailCodeFlashandSetNoticeFlashpublic inlogin/flash.goand update references.login/builder.go,login/middleware.go,login/view_helper.go,login/messages.go; minor touches inlogin/claims.go,login/user_logincode.go,login/views.go.ui/vuetifyx/vuetifyxjs/dist/vuetifyx.jsandui/vuetifyx/vuetifyxjs/dist/assets/vuetifyx.min.css.Written by Cursor Bugbot for commit 991a9c9. This will update automatically on new commits. Configure here.