Skip to content

Conversation

@eideroliveira
Copy link

@eideroliveira eideroliveira commented Apr 22, 2025

Those functions are useful when you have custom forms


Note

Export SetFailCodeFlash and SetNoticeFlash, update related login modules, and rebuild vuetifyx assets.

  • Backend (gologin):
    • Exports: Make SetFailCodeFlash and SetNoticeFlash public in login/flash.go and update references.
    • Related updates: Adjustments across login/builder.go, login/middleware.go, login/view_helper.go, login/messages.go; minor touches in login/claims.go, login/user_logincode.go, login/views.go.
  • Frontend:
    • Build: Rebuilt ui/vuetifyx/vuetifyxjs/dist/vuetifyx.js and ui/vuetifyx/vuetifyxjs/dist/assets/vuetifyx.min.css.

Written by Cursor Bugbot for commit 991a9c9. This will update automatically on new commits. Configure here.

@danni-cool danni-cool requested a review from xuxinx May 13, 2025 03:52
@xuxinx xuxinx requested review from molon and removed request for xuxinx May 13, 2025 03:54
cursor[bot]

This comment was marked as outdated.

@theplant-ci theplant-ci added size/XL and removed size/M labels Sep 4, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

// if r.Method == http.MethodGet {
b.setContinueURL(w, r)
}
// }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Method Handling Causes Login Redirection Issues

The if r.Method == http.MethodGet check was commented out, causing setContinueURL to be called for all HTTP methods. This saves non-GET requests (like form submissions) as continue URLs. After login, users are redirected to these action endpoints, which can lead to "Method Not Allowed" errors or lost form data, disrupting the user flow.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

}

web.Page(b.loginCodePageFunc).ServeHTTP(w, r)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Login Flow Broken: Account Lost

After sending the login code, sendUserCodeLogin serves the login code page directly without passing the account parameter. The login code validation page expects account in the URL query string to populate a hidden form field, but it's only available in the POST form values. This causes the account to be lost when the user submits the login code, breaking the login flow.

Fix in Cursor Fix in Web

… pnpm version

fix: add decimal separator support in VXField.vue

build: configure Vite to disable minification and change entry file name

chore: add generated vuetifyx.js to distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants