SLF4J-256: Fluent API improvement #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianshum
commented
Dec 19, 2021
adrianshum
commented
- adding message() in event builder, to allow message to be provided before arguments
- adding arg() as alias of addArgument()
- some typo fixes
- adding message() in event builder, to allow message to be provided before arguments - adding arg() as alias of addArgument() - some typo fixes Signed-off-by: Adrian Shum <[email protected]>
adrianshum
force-pushed
the
feature/SLF4J-256_FluentApi
branch
from
189cc6e to
ac3f21a
Compare
|
@adrianshum Thank you for this PR. The |
If static analysis was provided to warn users of incorrect usage, would you consider this to have enough usability? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.