Repository navigation
Own application state by reactive root and require complete CI - #406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppContext now owns each App root's signals and ECS; charts retain that owner, disposal aborts its streams, and callbacks ignore disposed owners. TooltipData/LineVisibility are neutral UI data with compatibility accessors for gradual migration.
Validation on b5d343f: 118 Rust browser tests (including all 3 lifecycle tests), 1 Node test, 7 Playwright/WebGPU scenarios, 2 Python regressions and 6 policy tests passed. Locked check/strict Clippy, actionlint/zizmor and all four CodeQL analyses passed. Main scanner has marked all 18 previous alerts fixed (zero open). Post-merge workflow results are tracked separately.
Limits: 49 legacy plain/QuickCheck cases compile but do not execute in the WASM harness; one native-only performance case is excluded. Native runtime execution is not established. Renderer/render queue remain shared services; UI/ECS isolation does not establish independent GPU renderers or physical-device FPS. No local external browser, live provider call or release dispatch was used.
References: F:src/app_context.rs#L87-L175, F:src/ui_state.rs#L1-L54, F:tests/app_context.rs, F:DOCS/TESTS.md#L37-L43, F:.github/workflows/ci.yml.