Repository navigation
Require measured WebGPU frame completion and reject missing performance data - #409
Merged
Merged
Conversation
qqrm
marked this pull request as ready for review
October 15, 2026 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance workflows passed with no FPS samples; timing ignored render errors and counted submission without waiting for GPU completion. This batch requires real completed-frame measurements and fails CI on absent/invalid data or a per-workload median regression over 30%.
Validation: formatting, locked all-feature checks, strict Clippy, actionlint and 10 Python regression tests passed. Hosted CI 38682129385 passed on ed16cfc: 117 browser Rust, 1 Node Rust, 7 Playwright, 10 Python tests; reference and candidate each passed 2 GPU tests and produced all 15 samples. Paired median changes were -0.01%, +9.09%, +0.61%; all security and CodeQL checks passed. Local cargo test builds WASM but cannot execute it directly on native Windows, so runtime execution uses hosted browsers.
Scope: cached LOD chart throughput with readback overhead on software SwiftShader. Physical GPU/display FPS, initial loading and live-update cost are not established. PR #407 contains additional major dependency migrations and is not superseded.
Code: F:tests/performance_limit.rs; F:scripts/parse_perf_log.py; F:scripts/compare_fps.py; F:.github/workflows/benchmark.yml; F:.github/workflows/PIPELINES.md.