Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): update to latest test suite #64

Merged
merged 2 commits into from
Apr 23, 2020
Merged

chore(tests): update to latest test suite #64

merged 2 commits into from
Apr 23, 2020

Conversation

Arqu
Copy link
Contributor

@Arqu Arqu commented Apr 23, 2020 •
edited
Loading

Simple update of the test suite, subsequent PR's will build on this to provide support for draft2019_09 and fix other failing tests.

Notable changes:

  • Pinned to go 1.13
  • Bumped CircleCI to load go 1.13
  • Added test suite for draft2019_09
  • Updated tests for older drafts
  • Disabled tests that were failing after the update
  • Bumped golint deps on CircleCI
  • Added schema details for draft2019_09
  • Cleaned up schema_test.go
  • Added preliminary test for the latest draft

Files that matter for review:

  • schema_test.go
  • go.mod
  • .circleci/config.yml

@Arqu Arqu requested a review from b5 April 23, 2020 09:18
@Arqu Arqu force-pushed the update-test-suite branch 2 times, most recently from d23ab43 to bec6f32 Compare April 23, 2020 09:22
@Arqu Arqu force-pushed the update-test-suite branch from bec6f32 to 83d4f78 Compare April 23, 2020 09:26
b5
b5 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for splitting this massive 13k addition into it's own PR 😄

@Arqu Arqu merged commit 3f1bc86 into master Apr 23, 2020
@Arqu Arqu deleted the update-test-suite branch April 23, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b5 b5 b5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arqu @b5