Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jsonschema): change error returned from json.Unmarshal to a wrapped error (#83) #85

Merged
merged 1 commit into from
Oct 28, 2020
Merged

refactor(jsonschema): change error returned from json.Unmarshal to a wrapped error (#83) #85

merged 1 commit into from
Oct 28, 2020

Conversation

aakhan1
Copy link
Contributor

@aakhan1 aakhan1 commented Oct 27, 2020

this allows the caller get to the underlying error

@aakhan1
refactor(jsonschema): change error returned from json.Unmarshal to wr…
44458fc 
…apped error (qri-io#83)

this allows the caller get to the underlying error
@aakhan1 aakhan1 marked this pull request as ready for review October 27, 2020 01:36
@Arqu Arqu self-requested a review October 27, 2020 10:51
@Arqu Arqu self-assigned this Oct 27, 2020
Arqu
Arqu approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you.

@Arqu Arqu merged commit 08d62a2 into qri-io:master Oct 28, 2020
@Arqu Arqu mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arqu Arqu Arqu approved these changes

Assignees

@Arqu Arqu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakhan1 @Arqu